Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove obsolete instruction #1078

Conversation

basti1302
Copy link
Contributor

@basti1302 basti1302 commented Jul 4, 2022

Which problem is this PR solving?

npm run bootstrap is ran as a postinstall lifecycle hook during npm install, thus executing it as a separate step is not necessary.

See

"postinstall": "npm run bootstrap",

Checklist

  • Not applicable -- ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@basti1302 basti1302 requested a review from a team July 4, 2022 15:42
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: basti1302 / name: Bastian Krol (81a89bf)

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #1078 (8dc8961) into main (8a90e78) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          13       13           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          821      821           
  Misses         35       35           

@rauno56
Copy link
Member

rauno56 commented Jul 5, 2022

@basti1302, please sign the CLA.

@basti1302
Copy link
Contributor Author

@basti1302, please sign the CLA.

I know, I know, it is work in progress. I am working with the CCLA managers at my org (IBM) to get me on the list.

@basti1302 basti1302 force-pushed the remove-obsolete-instruction-from-contributing-md branch 2 times, most recently from db6b4c8 to 81a89bf Compare July 8, 2022 11:50
@vmarchaud
Copy link
Member

@basti1302 you'll need to rebase

@basti1302 basti1302 force-pushed the remove-obsolete-instruction-from-contributing-md branch from 81a89bf to 01d74f1 Compare July 26, 2022 16:21
@basti1302 basti1302 force-pushed the remove-obsolete-instruction-from-contributing-md branch from 01d74f1 to 3b0a968 Compare August 9, 2022 06:56
@basti1302 basti1302 force-pushed the remove-obsolete-instruction-from-contributing-md branch from 3b0a968 to 8dc8961 Compare August 9, 2022 10:21
@basti1302
Copy link
Contributor Author

I think this is trivial change is ready to be merged.

@Flarna Flarna merged commit 57cedc5 into open-telemetry:main Aug 9, 2022
@basti1302 basti1302 deleted the remove-obsolete-instruction-from-contributing-md branch August 9, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants