Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean tav versions #1064

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jun 20, 2022

Which problem is this PR solving?

[email protected] pulls it's types from git - that takes for forever - installing that version took 13:08 locally. TAV doesn't like it and retries.
This PR removes that version from the tav run. Also cleaned up few others while I was at it.

Short description of the changes

Cleaned up tav version ranges for:

  • aws-sdk <- must regularly be narrowed because they do a release every single day. 🎉
  • ioredis
  • mysql2
  • pino

Didn't collect the exact numbers on the coverage vs version count, but tried to stick to a good balance between.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1064 (85288c3) into main (bb39a9e) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 85288c3 differs from pull request most recent head 9919549. Consider uploading reports for the commit 9919549 to get more accurate results

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   95.91%   95.93%   +0.02%     
==========================================
  Files          13       29      +16     
  Lines         856     1674     +818     
  Branches      178      350     +172     
==========================================
+ Hits          821     1606     +785     
- Misses         35       68      +33     
Impacted Files Coverage Δ
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.44% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.36% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...etry-instrumentation-mysql2/src/instrumentation.ts 94.36% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-pino/src/instrumentation.ts 100.00% <0.00%> (ø)
...try-instrumentation-ioredis/src/instrumentation.ts 91.35% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 87.87% <0.00%> (ø)
... and 6 more

@rauno56 rauno56 merged commit 78b5d61 into open-telemetry:main Jun 22, 2022
@rauno56 rauno56 deleted the chore/tav-version-cut branch June 22, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants