Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix homepage links #1032

Merged
merged 3 commits into from
May 26, 2022

Conversation

ledniy
Copy link
Contributor

@ledniy ledniy commented May 24, 2022

Which problem is this PR solving?

Short description of the changes

  • Fix the homepage to the relevant directory

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@ledniy ledniy requested a review from a team May 24, 2022 07:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 24, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ledniy / name: Vlad Goldman (8a21019)

@ledniy ledniy changed the title fix: homepage links docs: homepage links May 24, 2022
@ledniy ledniy changed the title docs: homepage links docs: fix homepage links May 24, 2022
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I just merged the redis-4 instrumentation, so please apply the change there as well when you you rebase :)

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1032 (5d9fc44) into main (4fd73a4) will decrease coverage by 4.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
- Coverage   95.91%   91.90%   -4.01%     
==========================================
  Files          13      131     +118     
  Lines         856     6104    +5248     
  Branches      178     1186    +1008     
==========================================
+ Hits          821     5610    +4789     
- Misses         35      494     +459     
Impacted Files Coverage Δ
...ges/opentelemetry-host-metrics/src/stats/common.ts 100.00% <0.00%> (ø)
...elemetry-instrumentation-pg/src/instrumentation.ts 82.47% <0.00%> (ø)
...emetry-instrumentation-hapi/src/instrumentation.ts 99.30% <0.00%> (ø)
...nstrumentation-connect/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ode/opentelemetry-instrumentation-net/src/utils.ts 90.47% <0.00%> (ø)
...opentelemetry-instrumentation-express/src/utils.ts 97.36% <0.00%> (ø)
...pentelemetry-instrumentation-knex/src/constants.ts 100.00% <0.00%> (ø)
...rc/background/ProgrammaticContentScriptInjector.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-knex/src/instrumentation.ts 98.78% <0.00%> (ø)
plugins/node/instrumentation-amqplib/src/utils.ts 95.38% <0.00%> (ø)
... and 108 more

@ledniy ledniy force-pushed the enhancement/homepage-links branch from 8a21019 to fc38f0c Compare May 24, 2022 13:08
@ledniy
Copy link
Contributor Author

ledniy commented May 24, 2022

@blumamir fixed in 2da9ad6

@blumamir blumamir merged commit 0dc580d into open-telemetry:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants