Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-sdk): sns span name should be with low cardinality #841

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

YanivD
Copy link
Member

@YanivD YanivD commented Jan 20, 2022

Short description of the changes

Short description of the changes

  • Span name will be phone_number send when publishing SNS to a phone number. As I implemented in ruby's instrumentation

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #841 (9b9fa04) into main (2e14f46) will increase coverage by 0.46%.
The diff coverage is n/a.

❗ Current head 9b9fa04 differs from pull request most recent head e96d802. Consider uploading reports for the commit e96d802 to get more accurate results

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   95.29%   95.75%   +0.46%     
==========================================
  Files          10       29      +19     
  Lines         701     1861    +1160     
  Branches      142      249     +107     
==========================================
+ Hits          668     1782    +1114     
- Misses         33       79      +46     
Impacted Files Coverage Δ
...etry-instrumentation-aws-sdk/test/dynamodb.test.ts 100.00% <0.00%> (ø)
...telemetry-instrumentation-aws-sdk/test/sqs.test.ts 89.51% <0.00%> (ø)
...entelemetry-instrumentation-fastify/src/version.ts 100.00% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 90.32% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
... and 9 more

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauno56 rauno56 merged commit 7032a33 into open-telemetry:main Jan 21, 2022
@dyladan dyladan mentioned this pull request Feb 28, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants