fix(aws-sdk): sns span name should be with low cardinality (#841)

* fix(aws-sdk): sns span name should be with low cardinality * fix(aws-sdk): update test * fix(aws-sdk): fix lint Co-authored-by: Rauno Viskus <[email protected]>
open-telemetry · Jan 21, 2022 · 7032a33 · 7032a33
1 parent 2e14f46
commit 7032a33
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/sns.ts b/plugins/node/opentelemetry-instrumentation-aws-sdk/src/services/sns.ts
@@ -44,7 +44,9 @@ export class SnsServiceExtension implements ServiceExtension {
         this.extractDestinationName(TopicArn, TargetArn, PhoneNumber);
 
       spanName = `${
-        spanAttributes[SemanticAttributes.MESSAGING_DESTINATION]
+        PhoneNumber
+          ? 'phone_number'
+          : spanAttributes[SemanticAttributes.MESSAGING_DESTINATION]
       } send`;
     }
 

diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/test/sns.test.ts b/plugins/node/opentelemetry-instrumentation-aws-sdk/test/sns.test.ts
@@ -101,7 +101,7 @@ describe('SNS', () => {
         .promise();
 
       const publishSpans = getTestSpans().filter(
-        (s: ReadableSpan) => s.name === `${PhoneNumber} send`
+        (s: ReadableSpan) => s.name === 'phone_number send'
       );
       expect(publishSpans.length).toBe(1);
       const publishSpan = publishSpans[0];