-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql2 - migrate to v3 in tests #2168
Labels
Comments
1 task
tpraxl
added a commit
to tpraxl/opentelemetry-js-contrib
that referenced
this issue
Sep 24, 2024
Update mysql2 dependency to latest version (@3.11.3) and fix tests. Problems during `npm run compile` were fixed by removing an unsafe and incorrect typecast.
tpraxl
added a commit
to tpraxl/opentelemetry-js-contrib
that referenced
this issue
Sep 24, 2024
Update mysql2 dependency to latest version (@3.11.3) and fix tests. Problems during `npm run compile` were fixed by removing an unsafe and incorrect typecast. Fixes open-telemetry#2168 Signed-off-by: Thomas Praxl <[email protected]>
blumamir
added a commit
that referenced
this issue
Nov 1, 2024
Signed-off-by: Thomas Praxl <[email protected]> Co-authored-by: Marc Pichler <[email protected]> Co-authored-by: Amir Blum <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
renovate opened up #2095 to upgrade
mysql2
package to a new version 3.While we only use it for tests, the security warning is not a concern for us, but the tests are not compiling with the new version as a dev dependency:
Not sure how tav is working properly.
In npm, seems that version 3 is the popular version, and v2 has security issues. So it does make sense to use the new version in instrumentation testing by default.
This issue closes #2095 which cannot merge, to track the task of upgrading the dev dependency to a more relevant version
The text was updated successfully, but these errors were encountered: