-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pino): removed the tav for versions ^8 #1146
Merged
dyladan
merged 2 commits into
open-telemetry:main
from
epsagon:fix/remove-pino-v8-support
Sep 1, 2022
Merged
fix(pino): removed the tav for versions ^8 #1146
dyladan
merged 2 commits into
open-telemetry:main
from
epsagon:fix/remove-pino-v8-support
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following issue: #1147 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
+ Coverage 96.07% 96.41% +0.33%
==========================================
Files 14 16 +2
Lines 892 1004 +112
Branches 191 208 +17
==========================================
+ Hits 857 968 +111
- Misses 35 36 +1
|
@dyladan Thanks for the reference, that is exactly what failed the tav. |
blumamir
approved these changes
Sep 1, 2022
dyladan
approved these changes
Sep 1, 2022
branch out of date. please allow maintainers to edit your branch or update the branch or it cannot be merged |
rauno56
approved these changes
Sep 1, 2022
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Pinto test-all-versions for versions <8 fail the test-all versions.
Also, according to the documentation, the instrumentation does not support versions that are greater than ^7.11.
Short description of the changes
Remove the testing for version <8 and open a new issue to support versions <8
The failed Ci:
https://github.com/open-telemetry/opentelemetry-js-contrib/runs/8117913889?check_suite_focus=true
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.