Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added instana resource detector #1084

Merged
merged 1 commit into from
Aug 8, 2022
Merged

feat: added instana resource detector #1084

merged 1 commit into from
Aug 8, 2022

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Jul 8, 2022 •
edited
Loading

Which problem is this PR solving?

This adds a vendor specific resource detector. It solves the problem of process and trace correlation.

Short description of the changes

Added Instana Resource detector and tests,

Checklist

  • Ran npm run test for the new package on the latest commit if applicable.
  • discuss usage of service.instance.id

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 8, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kirrg001 / name: Katharina Irrgang (e5d2d08)

@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch 2 times, most recently from e5d2d08 to a611a16 Compare July 13, 2022 10:20
@github-actions github-actions bot requested a review from basti1302 July 13, 2022 10:20
@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch 6 times, most recently from 6764749 to 8355edd Compare July 14, 2022 09:55
@kirrg001 kirrg001 marked this pull request as ready for review July 14, 2022 10:02
@kirrg001 kirrg001 requested a review from a team July 14, 2022 10:02
@kirrg001 kirrg001 mentioned this pull request Jul 14, 2022
Closed
6 tasks
dyladan
dyladan approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % readme nit

detectors/node/opentelemetry-resource-detector-instana/README.md Outdated Show resolved Hide resolved
dyladan
dyladan requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry to the release please manifest

@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #1084 (087b24f) into main (4067652) will not change coverage.
The diff coverage is n/a.

❗ Current head 087b24f differs from pull request most recent head 1db6557. Consider uploading reports for the commit 1db6557 to get more accurate results

@@           Coverage Diff           @@
##             main    #1084   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          13       13           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          821      821           
  Misses         35       35

@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch 2 times, most recently from dee91e1 to 489cb3a Compare July 15, 2022 07:21
@kirrg001
Copy link
Contributor Author

Extended README description and added the new package to the release please manifest.

vmarchaud
vmarchaud approved these changes Jul 15, 2022
View reviewed changes
release-please-config.json Outdated Show resolved Hide resolved
@vmarchaud vmarchaud requested a review from dyladan July 15, 2022 09:04
blumamir
blumamir reviewed Jul 18, 2022
View reviewed changes
detectors/node/opentelemetry-resource-detector-instana/README.md Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/README.md Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/README.md Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/README.md Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Outdated Show resolved Hide resolved
detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Outdated Show resolved Hide resolved
@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch 6 times, most recently from 8a22715 to 43db7bb Compare July 20, 2022 11:29
@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch from 43db7bb to de4a685 Compare July 20, 2022 11:32
@kirrg001 kirrg001 requested a review from blumamir July 20, 2022 11:35
@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch from de4a685 to 39d402f Compare July 21, 2022 07:47
@basti1302 basti1302 mentioned this pull request Jul 26, 2022
Merged
1 task
basti1302
basti1302 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@basti1302 basti1302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

detectors/node/opentelemetry-resource-detector-instana/src/detectors/InstanaAgentDetector.ts Outdated Show resolved Hide resolved
@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch 3 times, most recently from ef25fcc to 65102f3 Compare August 8, 2022 10:18
@kirrg001 kirrg001 force-pushed the feat/instana-resource-detector branch from 65102f3 to 1db6557 Compare August 8, 2022 10:22
@dyladan dyladan merged commit 845f50c into open-telemetry:main Aug 8, 2022
@dyladan dyladan mentioned this pull request Aug 8, 2022
Merged
@basti1302 basti1302 deleted the feat/instana-resource-detector branch August 9, 2022 06:58
@basti1302 basti1302 removed their assignment Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@basti1302 basti1302 basti1302 approved these changes

@dyladan dyladan dyladan approved these changes

@blumamir blumamir Awaiting requested review from blumamir

Assignees

@kirrg001 kirrg001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kirrg001 @basti1302 @dyladan @vmarchaud @blumamir