-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid type imports of the aws-sdk package in the built assets #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
+ Coverage 96.07% 96.61% +0.53%
==========================================
Files 14 25 +11
Lines 892 1446 +554
Branches 191 308 +117
==========================================
+ Hits 857 1397 +540
- Misses 35 49 +14
|
blumamir
approved these changes
Jun 27, 2022
Just wanted to let you know there is a service desk ticket for this CNCFSD-1369 |
looks like if we don't modify their types we would just preserve their copyright notice and not add our own |
Added 3rd party copyright notice because we do change them slightly. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is a subset of #1017 that touches
aws-sdk
types because of the legal discussion holding merging those back.Short description of the changes
See #1017
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.