fix: pass resourceDetectors

open-telemetry · Nov 11, 2022 · 1da1280 · 1da1280
1 parent 04d251b
commit 1da1280
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/detectors/node/opentelemetry-resource-detector-instana/README.md b/detectors/node/opentelemetry-resource-detector-instana/README.md
@@ -36,13 +36,12 @@ const globalResource = new Resource({
 
 const sdk = new NodeSDK({
    autoDetectResources: false,
+   resourceDetectors: [envDetector, processDetector, instanaAgentDetector],
    resource: globalResource,
 });
 
 (async () => {
-   await sdk.detectResources({
-      detectors: [envDetector, processDetector, instanaAgentDetector],
-   });
+   await sdk.detectResources();
 
    await sdk.start();
 }());

diff --git a/.../opentelemetry-resource-detector-instana/test/InstanaAgentDetectorIntegrationTest.test.ts b/.../opentelemetry-resource-detector-instana/test/InstanaAgentDetectorIntegrationTest.test.ts
@@ -54,13 +54,12 @@ describe('[Integration] instanaAgentDetector', () => {
 
     const sdk = new NodeSDK({
       autoDetectResources: false,
+      resourceDetectors: [envDetector, processDetector, instanaAgentDetector],
       resource: globalResource,
     });
 
     // attributes are automatically merged!
-    await sdk.detectResources({
-      detectors: [envDetector, processDetector, instanaAgentDetector],
-    });
+    await sdk.detectResources();
 
     const resource = sdk['_resource'];