chore: remove support for node 8-12, add 18 (#1065)

* chore: remove node 8 and 10 from CI * chore: update engines * chore: add node 18 to CI * fix(resource-detector-alibaba-cloud): call .destroy() directly on the socket * test: reference the actual error message * test(instrumentation-fastify): check for similarity with ROOT_CONTEXT, not reference equality In the CI there will be 3 instances of the API installed(relative to the repo root): - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`, - `./node_modules/@opentelemetry/api`, - `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`. * chore: remove support for node@12 updating the engines * chore: remove test runs on node@12 * test(resource-detector-alibaba-cloud): revert change, disable tests for node@18 * fix: turn fastify tests off for node@18
open-telemetry · Sep 15, 2022 · 1277ce4 · 1277ce4
1 parent 6c75487
commit 1277ce4
Show file tree

Hide file tree

Showing 55 changed files with 77 additions and 97 deletions.
diff --git a/.github/workflows/test-all-versions.yml b/.github/workflows/test-all-versions.yml
@@ -15,26 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ["8", "10", "12", "14", "16"]
-        include:
-          - node: "8"
-            lerna-extra-args: >-
-              --ignore @opentelemetry/instrumentation-aws-sdk
-              --ignore @opentelemetry/instrumentation-pino
-              --ignore @opentelemetry/instrumentation-tedious
-              --ignore @opentelemetry/instrumentation-amqplib
-              --ignore @opentelemetry/instrumentation-mongodb
-              --ignore @opentelemetry/instrumentation-redis-4
-              --ignore @opentelemetry/instrumentation-hapi
-              --ignore @opentelemetry/instrumentation-nestjs-core
-          - node: "10"
-            lerna-extra-args: >-
-              --ignore @opentelemetry/instrumentation-aws-sdk
-              --ignore @opentelemetry/instrumentation-pino
-              --ignore @opentelemetry/instrumentation-mongodb
-              --ignore @opentelemetry/instrumentation-redis-4
-              --ignore @opentelemetry/instrumentation-hapi
-              --ignore @opentelemetry/instrumentation-nestjs-core
+        node: ["14", "16", "18"]
     runs-on: ubuntu-latest
     services:
       memcached:

diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -9,26 +9,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ["8", "10", "12", "14", "16"]
+        node: ["14", "16", "18"]
         include:
-          - node: "8"
+          # tests fail on node@18, incompatibility with nock?
+          - node: "18"
             lerna-extra-args: >-
-              --ignore @opentelemetry/instrumentation-aws-sdk
-              --ignore @opentelemetry/instrumentation-pino
-              --ignore @opentelemetry/instrumentation-tedious
-              --ignore @opentelemetry/instrumentation-amqplib
-              --ignore @opentelemetry/instrumentation-redis-4
-              --ignore @opentelemetry/instrumentation-hapi
-          - node: "10"
-            lerna-extra-args: >-
-              --ignore @opentelemetry/instrumentation-aws-sdk
-              --ignore @opentelemetry/instrumentation-pino
-              --ignore @opentelemetry/instrumentation-redis-4
-              --ignore @opentelemetry/instrumentation-hapi
-          - node: "12"
-            lerna-extra-args: >-
-              --ignore @opentelemetry/instrumentation-redis-4
-              --ignore @opentelemetry/instrumentation-pino
+              --ignore @opentelemetry/resource-detector-alibaba-cloud
+              --ignore @opentelemetry/instrumentation-fastify
     runs-on: ubuntu-latest
     services:
       memcached:
@@ -174,7 +161,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ["12"]
+        node: ["14"]
     runs-on: ubuntu-latest
     env:
       NPM_CONFIG_UNSAFE_PERM: true

diff --git a/archive/opentelemetry-browser-extension-autoinjection/package.json b/archive/opentelemetry-browser-extension-autoinjection/package.json
@@ -23,7 +23,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "peerDependencies": {
     "@opentelemetry/api": "^1.0.0"

diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/detectors/node/opentelemetry-resource-detector-aws/package.json b/detectors/node/opentelemetry-resource-detector-aws/package.json
@@ -27,7 +27,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/detectors/node/opentelemetry-resource-detector-docker/package.json b/detectors/node/opentelemetry-resource-detector-docker/package.json
@@ -22,7 +22,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/detectors/node/opentelemetry-resource-detector-gcp/package.json b/detectors/node/opentelemetry-resource-detector-gcp/package.json
@@ -27,7 +27,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/detectors/node/opentelemetry-resource-detector-github/package.json b/detectors/node/opentelemetry-resource-detector-github/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/metapackages/auto-instrumentations-node/package.json b/metapackages/auto-instrumentations-node/package.json
@@ -6,7 +6,7 @@
   "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-node#readme",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "publishConfig": {
     "access": "public"

diff --git a/metapackages/auto-instrumentations-web/package.json b/metapackages/auto-instrumentations-web/package.json
@@ -6,7 +6,7 @@
   "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-web#readme",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/opentelemetry-host-metrics/package.json b/packages/opentelemetry-host-metrics/package.json
@@ -29,7 +29,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/packages/opentelemetry-id-generator-aws-xray/package.json b/packages/opentelemetry-id-generator-aws-xray/package.json
@@ -37,7 +37,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/esm/**/*.js",

diff --git a/packages/opentelemetry-propagation-utils/package.json b/packages/opentelemetry-propagation-utils/package.json
@@ -32,7 +32,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "bugs": {
     "url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues"

diff --git a/packages/opentelemetry-test-utils/package.json b/packages/opentelemetry-test-utils/package.json
@@ -31,7 +31,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "bugs": {
     "url": "https://github.com/open-telemetry/opentelemetry-js-contrib/issues"

diff --git a/plugins/node/instrumentation-amqplib/package.json b/plugins/node/instrumentation-amqplib/package.json
@@ -70,6 +70,6 @@
     "typescript": "4.3.5"
   },
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=14"
   }
 }
diff --git a/plugins/node/instrumentation-fs/package.json b/plugins/node/instrumentation-fs/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/instrumentation-lru-memoizer/package.json b/plugins/node/instrumentation-lru-memoizer/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/instrumentation-tedious/package.json b/plugins/node/instrumentation-tedious/package.json
@@ -33,7 +33,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json b/plugins/node/opentelemetry-instrumentation-aws-lambda/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json b/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json
@@ -78,6 +78,6 @@
     "typescript": "4.3.4"
   },
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=14"
   }
 }
diff --git a/plugins/node/opentelemetry-instrumentation-bunyan/package.json b/plugins/node/opentelemetry-instrumentation-bunyan/package.json
@@ -30,7 +30,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-cassandra/package.json b/plugins/node/opentelemetry-instrumentation-cassandra/package.json
@@ -29,7 +29,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-connect/package.json b/plugins/node/opentelemetry-instrumentation-connect/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-dns/package.json b/plugins/node/opentelemetry-instrumentation-dns/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-express/examples/package.json b/plugins/node/opentelemetry-instrumentation-express/examples/package.json
@@ -21,7 +21,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",

diff --git a/plugins/node/opentelemetry-instrumentation-express/package.json b/plugins/node/opentelemetry-instrumentation-express/package.json
@@ -31,7 +31,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-fastify/package.json b/plugins/node/opentelemetry-instrumentation-fastify/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts b/plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts
@@ -15,7 +15,7 @@
  */
 
 import * as assert from 'assert';
-import { context, ROOT_CONTEXT, SpanStatusCode } from '@opentelemetry/api';
+import { context, SpanStatusCode } from '@opentelemetry/api';
 import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
@@ -72,6 +72,14 @@ import { FastifyInstance } from 'fastify/types/instance';
 
 const Fastify = require('fastify');
 
+const assertRootContextActive = () => {
+  // Asserting the context.active() to strictly equal ROOT_CONTEXT doesn't
+  // always work because of the linking and dep resolution.
+  // Specially in our CI environment there can be multiple instances to
+  // different @opentelemetry/api and thus ROOT_CONTEXTs in the tree.
+  assert.strictEqual((context.active() as any)['_currentContext'].size, 0);
+};
+
 function getSpans(): ReadableSpan[] {
   const spans = memoryExporter.getFinishedSpans().filter(s => {
     return (
@@ -367,9 +375,14 @@ describe('fastify', () => {
     });
 
     describe('application hooks', () => {
+      afterEach(() => {
+        const spans = getSpans();
+        assert.strictEqual(spans.length, 0);
+      });
+
       it('onRoute not instrumented', async () => {
         app.addHook('onRoute', () => {
-          assert.strictEqual(context.active(), ROOT_CONTEXT);
+          assertRootContextActive();
         });
         // add a route to trigger the 'onRoute' hook
         app.get('/test', (_req: FastifyRequest, reply: FastifyReply) => {
@@ -381,7 +394,7 @@ describe('fastify', () => {
 
       it('onRegister is not instrumented', async () => {
         app.addHook('onRegister', () => {
-          assert.strictEqual(context.active(), ROOT_CONTEXT);
+          assertRootContextActive();
         });
         // register a plugin to trigger 'onRegister' hook
         app.register((fastify, options, done) => {
@@ -393,19 +406,18 @@ describe('fastify', () => {
 
       it('onReady is not instrumented', async () => {
         app.addHook('onReady', () => {
-          assert.strictEqual(context.active(), ROOT_CONTEXT);
+          assertRootContextActive();
         });
 
         await startServer();
       });
 
       it('onClose is not instrumented', async () => {
         app.addHook('onClose', () => {
-          assert.strictEqual(context.active(), ROOT_CONTEXT);
+          assertRootContextActive();
         });
 
         await startServer();
-        await app.close();
       });
     });
   });

diff --git a/plugins/node/opentelemetry-instrumentation-generic-pool/package.json b/plugins/node/opentelemetry-instrumentation-generic-pool/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-graphql/package.json b/plugins/node/opentelemetry-instrumentation-graphql/package.json
@@ -30,7 +30,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-hapi/package.json b/plugins/node/opentelemetry-instrumentation-hapi/package.json
@@ -28,7 +28,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",

diff --git a/plugins/node/opentelemetry-instrumentation-ioredis/package.json b/plugins/node/opentelemetry-instrumentation-ioredis/package.json
@@ -33,7 +33,7 @@
   "author": "OpenTelemetry Authors",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=8.12.0"
+    "node": ">=14"
   },
   "files": [
     "build/src/**/*.js",