Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the missing enclosing interface #854

Conversation

jkwatson
Copy link
Contributor

This causes warnings, and with some compilers, errors. Adding the enclosing interface reference quiets that down.

@codecov-io
Copy link

Codecov Report

Merging #854 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #854   +/-   ##
========================================
  Coverage      79.3%   79.3%           
  Complexity      797     797           
========================================
  Files           106     106           
  Lines          2865    2865           
  Branches        268     268           
========================================
  Hits           2272    2272           
  Misses          492     492           
  Partials        101     101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bd0b5...f294322. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this in CI.

@bogdandrutu bogdandrutu merged commit 1e7239e into open-telemetry:master Feb 13, 2020
@jkwatson jkwatson deleted the add_enclosing_interface_reference branch February 28, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants