-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic Long and Double gauge implementation #764
Add a basic Long and Double gauge implementation #764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
===========================================
- Coverage 78.84% 78.45% -0.4%
- Complexity 761 767 +6
===========================================
Files 98 100 +2
Lines 2709 2771 +62
Branches 255 265 +10
===========================================
+ Hits 2136 2174 +38
- Misses 473 495 +22
- Partials 100 102 +2
Continue to review full report at Codecov.
|
sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java
Outdated
Show resolved
Hide resolved
sdk/src/main/java/io/opentelemetry/sdk/metrics/SdkLongGauge.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for getting this done!
Thank you for this PR @thisthat, I will hold on merging this PR until we discuss open-telemetry/opentelemetry-specification#412. If you think we should make progress we can merge it and maybe remove later if the decision will be to remove the Gauge instrument. |
I would argue to hold this PR until a decision at the specification level is taken. If the Gauge API will change/remove, I will update/delete this PR accordingly. |
Based on the open-telemetry/oteps#80, I will close this PR, feel free to reopen if needed. |
This addresses #684 and it is implemented following #755