Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic Long and Double gauge implementation #764

Closed

Conversation

thisthat
Copy link
Member

This addresses #684 and it is implemented following #755

@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #764 into master will decrease coverage by 0.39%.
The diff coverage is 59.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #764     +/-   ##
===========================================
- Coverage     78.84%   78.45%   -0.4%     
- Complexity      761      767      +6     
===========================================
  Files            98      100      +2     
  Lines          2709     2771     +62     
  Branches        255      265     +10     
===========================================
+ Hits           2136     2174     +38     
- Misses          473      495     +22     
- Partials        100      102      +2
Impacted Files Coverage Δ Complexity Δ
...in/java/io/opentelemetry/sdk/metrics/MeterSdk.java 41.66% <0%> (ø) 5 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/SdkDoubleGauge.java 61.29% <61.29%> (ø) 3 <3> (?)
...ava/io/opentelemetry/sdk/metrics/SdkLongGauge.java 61.29% <61.29%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5517dcb...edb9476. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting this done!

@bogdandrutu
Copy link
Member

Thank you for this PR @thisthat, I will hold on merging this PR until we discuss open-telemetry/opentelemetry-specification#412. If you think we should make progress we can merge it and maybe remove later if the decision will be to remove the Gauge instrument.

@thisthat
Copy link
Member Author

thisthat commented Jan 17, 2020

I would argue to hold this PR until a decision at the specification level is taken. If the Gauge API will change/remove, I will update/delete this PR accordingly.

@bogdandrutu
Copy link
Member

Based on the open-telemetry/oteps#80, I will close this PR, feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants