Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prom client #6857

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

zeitlinger
Copy link
Member

No description provided.

@zeitlinger zeitlinger requested a review from a team as a code owner November 7, 2024 18:00
@zeitlinger zeitlinger self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.28%. Comparing base (6c3725d) to head (ce73e61).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../exporter/prometheus/Otel2PrometheusConverter.java 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6857   +/-   ##
=========================================
  Coverage     90.28%   90.28%           
  Complexity     6588     6588           
=========================================
  Files           729      729           
  Lines         19768    19768           
  Branches       1944     1944           
=========================================
+ Hits          17847    17848    +1     
  Misses         1327     1327           
+ Partials        594      593    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the upstream generics change was being rolled back. If that's the case, will we need to revert the corresponding changes in this pr when the new version is available?

@zeitlinger
Copy link
Member Author

This PR already includes the rollback of the incompatible API changes

@jack-berg jack-berg merged commit 2a1c274 into open-telemetry:main Nov 8, 2024
24 of 25 checks passed
@zeitlinger zeitlinger deleted the prom-client-update branch November 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants