Bump config file format version #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
bump-config-format-number
branch
from
c70820c to
0339e4e
Compare
trask
force-pushed
the
bump-config-format-number
branch
from
0339e4e to
0868ed7
Compare
jack-berg
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Yeah its a bummer we missed this. Opened open-telemetry/opentelemetry-configuration#132 to prevent issues like this in the future.
|
Why close the PR? |
|
oops! I was cleaning up old branches and I thought this one was merged already |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6786 +/- ##
============================================
- Coverage 90.12% 90.11% -0.02%
+ Complexity 6546 6545 -1
============================================
Files 728 728
Lines 19702 19702
Branches 1935 1935
============================================
- Hits 17756 17754 -2
Misses 1347 1347
- Partials 599 601 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(CI failing until #6785 is merged and this is rebased)