Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdout exporter for span and metrics #6750

Merged

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Sep 26, 2024

Follow up to #6675

@zeitlinger zeitlinger requested a review from a team as a code owner September 26, 2024 13:33
@zeitlinger zeitlinger self-assigned this Sep 26, 2024
@zeitlinger zeitlinger mentioned this pull request Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 93.40102% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.11%. Comparing base (7f8fbc9) to head (dbc35fa).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...lemetry/exporter/internal/ExporterBuilderUtil.java 79.06% 6 Missing and 3 partials ⚠️
...tlp/internal/metrics/OtlpStdoutMetricExporter.java 93.54% 1 Missing and 1 partial ⚠️
...g/otlp/internal/traces/OtlpStdoutSpanExporter.java 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6750      +/-   ##
============================================
+ Coverage     90.03%   90.11%   +0.07%     
- Complexity     6475     6521      +46     
============================================
  Files           718      726       +8     
  Lines         19573    19669      +96     
  Branches       1931     1935       +4     
============================================
+ Hits          17622    17724     +102     
+ Misses         1353     1346       -7     
- Partials        598      599       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zeitlinger
Copy link
Member Author

@jack-berg here's the PR that brings metrics and spans to the same level as logs were before

memory mode will be the final PR

@zeitlinger zeitlinger force-pushed the stdout-exporter-span-and-metrics branch from 4084624 to 9e63bff Compare October 1, 2024 10:04
@jack-berg jack-berg merged commit b927d9d into open-telemetry:main Oct 9, 2024
18 checks passed
@zeitlinger zeitlinger deleted the stdout-exporter-span-and-metrics branch October 10, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants