Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context info about wrong span or trace #6703

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

zeitlinger
Copy link
Member

No description provided.

@zeitlinger zeitlinger requested a review from a team September 10, 2024 12:06
@zeitlinger zeitlinger self-assigned this Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (9ddccad) to head (6b41848).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6703   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity     6390     6390           
=========================================
  Files           711      711           
  Lines         19333    19333           
  Branches       1891     1891           
=========================================
  Hits          17418    17418           
  Misses         1335     1335           
  Partials        580      580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zeitlinger
Copy link
Member Author

@jack-berg this really helps with complicated asserts

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jack-berg jack-berg merged commit c9c857c into open-telemetry:main Sep 18, 2024
18 checks passed
@zeitlinger zeitlinger deleted the trace-assert-index branch September 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants