Remove android animalsniffer check from prometheus exporter #6478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to scrape metrics from an android device. Furthermore, the android API doesn't contain
com.sun.net.httpserver.HttpHandler
and this is a key part of the implementation of prometheus. So animalsniffer checks for usages of unsupported APIs directly, it doesn't appear to walk all the code paths so it missed this usage in the prometheus client library dependency.See convo in #6476 for more details.