-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize synchronous gauge #6419
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
============================================
- Coverage 90.92% 90.90% -0.02%
- Complexity 6165 6167 +2
============================================
Files 678 678
Lines 18453 18484 +31
Branches 1812 1813 +1
============================================
+ Hits 16778 16803 +25
- Misses 1141 1146 +5
- Partials 534 535 +1 ☔ View full report in Codecov by Sentry. |
/** | ||
* Builds and returns a DoubleGauge instrument with the configuration. | ||
* | ||
* <p>NOTE: This produces a synchronous gauge which records gauge values as they occur. Most users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something about how only the most recent one is exported, since I think that part of synchronous gauges is most likely to trip people up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a comment to that effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Synchronous gauges are now stable in the spec: open-telemetry/opentelemetry-specification#4019
Resolves #5795.