Add is_remote_parent span flags to OTLP exported Spans and SpanLinks #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWert
force-pushed
the
traceflags
branch
2 times, most recently
from
e79e3ee
to
cd48de6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6388 +/- ##
============================================
+ Coverage 91.05% 91.10% +0.05%
- Complexity 5839 5850 +11
============================================
Files 635 636 +1
Lines 17017 17036 +19
Branches 1729 1730 +1
============================================
+ Hits 15495 15521 +26
+ Misses 1023 1020 -3
+ Partials 499 495 -4 ☔ View full report in Codecov by Sentry. |
breedx-splk
reviewed
Apr 16, 2024
.../common/src/main/java/io/opentelemetry/exporter/internal/otlp/traces/ProtoSpanFlagsUtil.java
Outdated
Show resolved
Hide resolved
.../common/src/main/java/io/opentelemetry/exporter/internal/otlp/traces/ProtoSpanFlagsUtil.java
Outdated
Show resolved
Hide resolved
.../otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/traces/SpanMarshaler.java
Outdated
Show resolved
Hide resolved
AlexanderWert
force-pushed
the
traceflags
branch
2 times, most recently
from
88db857
to
b9d8496
Compare
jack-berg
reviewed
Apr 18, 2024
api/all/src/main/java/io/opentelemetry/api/trace/ImmutableTraceFlags.java
Outdated
Show resolved
Hide resolved
api/all/src/main/java/io/opentelemetry/api/trace/TraceFlags.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Apr 19, 2024
...ters/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/traces/SpanFlags.java
Show resolved
Hide resolved
breedx-splk
reviewed
Apr 19, 2024
sdk/trace/src/test/java/io/opentelemetry/sdk/trace/SdkSpanTest.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Apr 19, 2024
jack-berg
approved these changes
Apr 19, 2024
Signed-off-by: Alexander Wert <[email protected]>
Signed-off-by: Alexander Wert <[email protected]>
Signed-off-by: Alexander Wert <[email protected]>
Signed-off-by: Alexander Wert <[email protected]>
AlexanderWert
force-pushed
the
traceflags
branch
from
3cf4d7a
to
cbf5987
Compare
|
@open-telemetry/java-maintainers I think this is ready to be merged |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the parent_is_remote trace flags when exporting a Span or a SpanLink through OTLP.
See: