Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exporter data classes for experimental profiling signal type. #6374
Add exporter data classes for experimental profiling signal type. #6374
Changes from 9 commits
a7af9cb
3044610
64da240
ae94404
f84df98
112796b
2fa0060
4d31472
ffb73b9
d6e7951
087ce89
a84e2f9
bda144f
55b8ab6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 27 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java#L27
Check warning on line 30 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java#L30
Check warning on line 35 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java#L35
Check warning on line 41 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/AggregationTemporality.java#L41
Check warning on line 13 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/BuildIdKind.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/BuildIdKind.java#L13
Check warning on line 16 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/BuildIdKind.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/BuildIdKind.java#L16
Check warning on line 19 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/BuildIdKind.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/BuildIdKind.java#L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we omit these and just have serializers know to reference
OtelEncodingutils.bytesFromBase16
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. No reason they have to follow the same pattern as the existing SpanContext API does.
Check warning on line 29 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/LinkData.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/LinkData.java#L29
Check warning on line 37 in exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/LinkData.java
Codecov / codecov/patch
exporters/otlp/profiles/src/main/java/io/opentelemetry/exporter/otlp/data/LinkData.java#L37