-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for Java 17 toolchain and fail if not found #6303
Conversation
Signed-off-by: Bogdan Drutu <[email protected]>
ead0a0c
to
8ca11c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6303 +/- ##
=========================================
Coverage 91.04% 91.04%
Complexity 5726 5726
=========================================
Files 625 625
Lines 16744 16744
Branches 1713 1713
=========================================
Hits 15244 15244
Misses 1006 1006
Partials 494 494 ☔ View full report in Codecov by Sentry. |
Yeah, we don't want to break users who are already on 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a commit which reflects this recommendation: #6303 (comment)
Updated the PR title
Hi, here from the release notes. You can actually configure Gradle to install the JDK version that is not present (17 in this case) when it is not found on the local system, this is a better experience than erroring and was the default up to Gradle 7.x or so. Just edit
See the official docs: https://docs.gradle.org/current/userguide/toolchains.html#sec:provisioning |
You cannot build unless java17 is installed, see https://github.com/open-telemetry/opentelemetry-java/blob/main/buildSrc/build.gradle.kts#L69