-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
header values are be expected to be W3C baggage encoded #6164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
============================================
- Coverage 90.99% 90.99% -0.01%
- Complexity 5646 5673 +27
============================================
Files 619 620 +1
Lines 16443 16542 +99
Branches 1663 1683 +20
============================================
+ Hits 14963 15052 +89
+ Misses 1017 1013 -4
- Partials 463 477 +14 ☔ View full report in Codecov by Sentry. |
Yes and no. The codecov target is a goal, not a strict requirement. Sometimes its not practical to have all the code paths covered. Although in this case it seems like it should be straight forward to trigger than exception, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the bug fix. Looks good, but let's try to cover the exception case.
exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/internal/OtlpConfigUtil.java
Outdated
Show resolved
Hide resolved
exporters/otlp/all/src/main/java/io/opentelemetry/exporter/otlp/internal/OtlpConfigUtil.java
Outdated
Show resolved
Hide resolved
…p/internal/OtlpConfigUtil.java Co-authored-by: jack-berg <[email protected]>
…p/internal/OtlpConfigUtil.java Co-authored-by: jack-berg <[email protected]>
Fond a way 😄 |
Waiting to merge until its clear whether this is going to be considered a breaking change or a bug fix based on this spec conversation: open-telemetry/opentelemetry-specification#3832 |
Blocked by open-telemetry/opentelemetry-specification#3832