Update dependency io.zipkin.reporter2:zipkin-reporter-bom to 3.1.1 #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
zipkin-reporter-3
branch
2 times, most recently
from
814e9ea
to
0f10a29
Compare
codefromthecrypt
force-pushed
the
zipkin-reporter-3
branch
from
0f10a29
to
f9fc997
Compare
codefromthecrypt
force-pushed
the
zipkin-reporter-3
branch
2 times, most recently
from
499a972
to
20d5406
Compare
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6129 +/- ##
=========================================
Coverage 91.01% 91.01%
- Complexity 5702 5710 +8
=========================================
Files 630 631 +1
Lines 16710 16727 +17
Branches 1656 1657 +1
=========================================
+ Hits 15208 15224 +16
- Misses 1047 1048 +1
Partials 455 455 ☔ View full report in Codecov by Sentry. |
codefromthecrypt
commented
Jan 9, 2024
| break; | ||
| default: | ||
| // Only possible if zipkin2 adds an encoding besides above, which is very unlikely. | ||
| throw new UnsupportedOperationException("unsupported encoding " + delegate.encoding()); |
There was a problem hiding this comment.
this can't be unit tested as the switch is on an enum
codefromthecrypt
force-pushed
the
zipkin-reporter-3
branch
from
8fdd09d
to
471d9b2
Compare
|
macos-latest 8 build died before starting. please kick it! |
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
zipkin-reporter-3
branch
from
471d9b2
to
56603ba
Compare
codefromthecrypt
changed the title
|
thanks for merging! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged, this will unlock spring-boot and micrometer tracing from zipkin reporter 2