Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only call SpanProcessor onStart / onEnd if required #6112

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jack-berg
Copy link
Member

Fixes #5930.

@jack-berg jack-berg requested a review from a team January 3, 2024 18:06
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b8f43) 90.95% compared to head (4ffe274) 90.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6112      +/-   ##
============================================
- Coverage     90.95%   90.94%   -0.01%     
- Complexity     5682     5683       +1     
============================================
  Files           628      628              
  Lines         16672    16674       +2     
  Branches       1651     1653       +2     
============================================
+ Hits          15164    15165       +1     
  Misses         1051     1051              
- Partials        457      458       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 63fe708 into open-telemetry:main Jan 3, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpanProcessor called even when isStartRequired / isEndRequired are false
2 participants