Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop NaN measurements to metric instruments #5859

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

jack-berg
Copy link
Member

Resolves #5846.

@jack-berg jack-berg requested a review from a team September 27, 2023 20:12
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...nternal/state/DefaultSynchronousMetricStorage.java 93.65% <100.00%> (+0.43%) ⬆️
...trics/internal/state/SdkObservableMeasurement.java 94.54% <100.00%> (+0.42%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit 7e67a84 into open-telemetry:main Oct 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics SDK should ignore NaN measurement values
3 participants