DefaultConfigProperties#getMap filters entries with blank values intead of throwing #5784

jack-berg · 2023-08-31T15:34:27Z

Solves #5769.

…ad of throwing

...i/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/internal/DefaultConfigProperties.java

codecov · 2023-09-01T17:50:16Z

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
...emetry/sdk/autoconfigure/spi/ConfigProperties.java	`ø`
...onfigure/spi/internal/DefaultConfigProperties.java	`100.00%`

📢 Thoughts on this report? Let us know!.

DefaultConfigProperties#getMap filters entries with blank values inte…

24893bc

…ad of throwing

jack-berg requested a review from a team August 31, 2023 15:34

mateuszrzeszutek approved these changes Aug 31, 2023

View reviewed changes

...i/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/internal/DefaultConfigProperties.java Outdated Show resolved Hide resolved

Fail if no = delimeter

39ba978

mateuszrzeszutek approved these changes Sep 4, 2023

View reviewed changes

jkwatson approved these changes Sep 6, 2023

View reviewed changes

jack-berg merged commit 3f152eb into open-telemetry:main Sep 7, 2023
17 checks passed