Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javadoc to allow null/empty attr values #5616

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

breedx-splk
Copy link
Contributor

Resolves #5501.

@breedx-splk breedx-splk requested a review from a team July 10, 2023 17:01
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (9b9efa6) 91.31% compared to head (93600c6) 91.30%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5616      +/-   ##
============================================
- Coverage     91.31%   91.30%   -0.02%     
+ Complexity     4982     4981       -1     
============================================
  Files           554      554              
  Lines         14749    14749              
  Branches       1376     1376              
============================================
- Hits          13468    13466       -2     
- Misses          887      888       +1     
- Partials        394      395       +1     
Impacted Files Coverage Δ
...src/main/java/io/opentelemetry/api/trace/Span.java 93.47% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 16e7113 into open-telemetry:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string should be a valid attribute value
3 participants