Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark opentelemetry-sdk-extension-autoconfigure as stable #5577

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

jack-berg
Copy link
Member

Resolves #5464.

We've made some recent changes to autoconfigure which on their surface might cause us to delay stabilization while we collect feedback, but on closer inspection none seem particularly risky:

I think we should mark autoconfigure stable for the next release, 1.28.0.

@jack-berg jack-berg requested a review from a team June 27, 2023 18:21
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (73597b1) 91.36% compared to head (e0cee38) 91.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5577      +/-   ##
============================================
- Coverage     91.36%   91.32%   -0.05%     
+ Complexity     4965     4963       -2     
============================================
  Files           552      552              
  Lines         14576    14576              
  Branches       1358     1358              
============================================
- Hits          13318    13312       -6     
- Misses          870      877       +7     
+ Partials        388      387       -1     
Impacted Files Coverage Δ
.../autoconfigure/AutoConfiguredOpenTelemetrySdk.java 100.00% <ø> (ø)
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 94.40% <ø> (ø)
.../autoconfigure/LogRecordExporterConfiguration.java 100.00% <ø> (ø)
...entelemetry/sdk/autoconfigure/NamedSpiManager.java 100.00% <ø> (ø)
...metry/sdk/autoconfigure/ResourceConfiguration.java 94.73% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's a giant step forward to stabilize this!

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jack-berg jack-berg merged commit 6ab37f1 into open-telemetry:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize opentelemetry-sdk-extension-autoconfigure
4 participants