Add support for low memory metric temporality setting #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
reviewed
Jun 20, 2023
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/data/AggregationTemporality.java
Outdated
Show resolved
Hide resolved
tylerbenson
force-pushed
the
tyler/low-memory
branch
4 times, most recently
from
fce1272
to
83dd5be
Compare
`otel.exporter.otlp.metrics.temporality.preference` and `OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE` now support `LOWMEMORY` or `LowMemory` settings. For more information, see https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md#additional-configuration.
tylerbenson
force-pushed
the
tyler/low-memory
branch
from
83dd5be
to
72e1d6f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5558 +/- ##
============================================
- Coverage 91.39% 91.38% -0.02%
- Complexity 4963 4967 +4
============================================
Files 550 550
Lines 14569 14574 +5
Branches 1358 1358
============================================
+ Hits 13316 13319 +3
- Misses 866 868 +2
Partials 387 387
☔ View full report in Codecov by Sentry. |
mateuszrzeszutek
approved these changes
Jun 21, 2023
jack-berg
reviewed
Jun 21, 2023
...etrics/src/main/java/io/opentelemetry/sdk/metrics/export/AggregationTemporalitySelector.java
Show resolved
Hide resolved
jack-berg
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otel.exporter.otlp.metrics.temporality.preferenceandOTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCEnow supportLOWMEMORYorLowMemorysettings.For more information, see https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md#additional-configuration.