Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTLP exporter artifact name in an error message #5541

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team June 15, 2023 12:18
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cf3b0ef) 91.38% compared to head (f3e5673) 91.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5541   +/-   ##
=========================================
  Coverage     91.38%   91.39%           
+ Complexity     4960     4958    -2     
=========================================
  Files           549      549           
  Lines         14566    14559    -7     
  Branches       1356     1356           
=========================================
- Hits          13311    13306    -5     
+ Misses          868      866    -2     
  Partials        387      387           
Impacted Files Coverage Δ
...lp/http/logs/OtlpHttpLogRecordExporterBuilder.java 90.00% <ø> (ø)
...lp/http/metrics/OtlpHttpMetricExporterBuilder.java 95.23% <ø> (ø)
...r/otlp/http/trace/OtlpHttpSpanExporterBuilder.java 90.00% <ø> (ø)
...lemetry/exporter/otlp/internal/OtlpConfigUtil.java 89.84% <ø> (ø)
...r/otlp/internal/OtlpLogRecordExporterProvider.java 100.00% <ø> (ø)
...rter/otlp/internal/OtlpMetricExporterProvider.java 100.00% <ø> (ø)
...porter/otlp/internal/OtlpSpanExporterProvider.java 100.00% <ø> (ø)
...elemetry/exporter/otlp/internal/OtlpUserAgent.java 100.00% <ø> (ø)
...er/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java 91.66% <ø> (ø)
...er/otlp/metrics/OtlpGrpcMetricExporterBuilder.java 100.00% <ø> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg
Copy link
Member

Nice catch. Thanks!

@jack-berg jack-berg merged commit 26dd5d8 into open-telemetry:main Jun 15, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the fix-error-message branch July 5, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants