Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uneecessary :exporter:otlp:common dependencies #5535

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jack-berg
Copy link
Member

:expoter:otlp:common is a shared dependencies used by :exporter:logging-otlp and :exporter:otlp:all. It primarily holds the custom serializers for converting data records into OTLP protobuf binary and json. Until recently, it was also a place for shared OTLP code between exporter:otlp:logs and :exporter:otlp:all, which included OTLP user agent stuff and common config stuff for the SPI providers. Now that there's no more :expoter:otlp:logs artifact, this shared code should be rolled into :exporter:otlp:all, allowing :exporter:otlp:common to drop its dependency on okhttp.

This means that :exporter:logging-otlp will no longer has an erroneous dependency on okhttp.

@jack-berg jack-berg requested a review from a team June 13, 2023 21:09
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f89fc05) 91.38% compared to head (011ba1c) 91.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5535   +/-   ##
=========================================
  Coverage     91.38%   91.39%           
+ Complexity     4959     4957    -2     
=========================================
  Files           549      549           
  Lines         14563    14556    -7     
  Branches       1356     1356           
=========================================
- Hits          13308    13303    -5     
+ Misses          868      866    -2     
  Partials        387      387           
Impacted Files Coverage Δ
...lp/http/logs/OtlpHttpLogRecordExporterBuilder.java 90.00% <ø> (ø)
...lp/http/metrics/OtlpHttpMetricExporterBuilder.java 95.23% <ø> (ø)
...r/otlp/http/trace/OtlpHttpSpanExporterBuilder.java 90.00% <ø> (ø)
...lemetry/exporter/otlp/internal/OtlpConfigUtil.java 89.84% <ø> (ø)
...r/otlp/internal/OtlpLogRecordExporterProvider.java 100.00% <ø> (ø)
...rter/otlp/internal/OtlpMetricExporterProvider.java 100.00% <ø> (ø)
...porter/otlp/internal/OtlpSpanExporterProvider.java 100.00% <ø> (ø)
...elemetry/exporter/otlp/internal/OtlpUserAgent.java 100.00% <ø> (ø)
...er/otlp/logs/OtlpGrpcLogRecordExporterBuilder.java 91.66% <ø> (ø)
...er/otlp/metrics/OtlpGrpcMetricExporterBuilder.java 100.00% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 0530e63 into open-telemetry:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants