Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpSenderProvider SPI #5533

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Jun 13, 2023

Followup to #5505. Related to #5351.

This adds a new HttpSenderProvider SPI interface for configuring different HttpSender implementations.

It also splits out the OkHttpSender into a new artifact opentelemetry-exporter-http-sender-okhttp.

Another followup PR will define a JDK based HttpSender in a new artifact opentelemetry-exporter-http-sender-jdk.

@jack-berg jack-berg requested a review from a team June 13, 2023 20:18
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: +0.02 🎉

Comparison is base (f89fc05) 91.38% compared to head (73a1ceb) 91.40%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5533      +/-   ##
============================================
+ Coverage     91.38%   91.40%   +0.02%     
- Complexity     4959     4963       +4     
============================================
  Files           549      550       +1     
  Lines         14563    14569       +6     
  Branches       1356     1358       +2     
============================================
+ Hits          13308    13317       +9     
+ Misses          868      866       -2     
+ Partials        387      386       -1     
Impacted Files Coverage Δ
...xporter/http/okhttp/internal/OkHttpHttpSender.java 98.43% <ø> (ø)
...ry/exporter/internal/http/HttpExporterBuilder.java 92.15% <91.66%> (+1.45%) ⬆️
...http/okhttp/internal/OkHttpHttpSenderProvider.java 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg
Copy link
Member Author

/easycla

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jack-berg !

@jack-berg jack-berg merged commit 8f1a7b1 into open-telemetry:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants