-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HttpSenderProvider SPI #5533
Merged
jack-berg
merged 2 commits into
open-telemetry:main
from
jack-berg:http-sender-provider
Jun 16, 2023
Merged
Add HttpSenderProvider SPI #5533
jack-berg
merged 2 commits into
open-telemetry:main
from
jack-berg:http-sender-provider
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5533 +/- ##
============================================
+ Coverage 91.38% 91.40% +0.02%
- Complexity 4959 4963 +4
============================================
Files 549 550 +1
Lines 14563 14569 +6
Branches 1356 1358 +2
============================================
+ Hits 13308 13317 +9
+ Misses 868 866 -2
+ Partials 387 386 -1
☔ View full report in Codecov by Sentry. |
/easycla |
brunobat
reviewed
Jun 14, 2023
exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporterBuilder.java
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Jun 14, 2023
exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporterBuilder.java
Show resolved
Hide resolved
brunobat
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jack-berg !
mateuszrzeszutek
approved these changes
Jun 16, 2023
jkwatson
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5505. Related to #5351.
This adds a new HttpSenderProvider SPI interface for configuring different HttpSender implementations.
It also splits out the OkHttpSender into a new artifact
opentelemetry-exporter-http-sender-okhttp
.Another followup PR will define a JDK based HttpSender in a new artifact
opentelemetry-exporter-http-sender-jdk
.