Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to auto update gradle wrapper #5511

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

jack-berg
Copy link
Member

No description provided.

@jack-berg jack-berg requested a review from a team June 7, 2023 22:01
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @trask this task fails without installing the JDK. Didn't see any reference to this in the docs for the update-gradle-wrapper-action, but updating the wrapper requires running a gradle daemon, which requires java to be installed. Maybe update-gradle-wrapper-action installs a lower version of java than is required by opentelemetry-java?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, i'm guessing it didn't spit out a useful error to give us any clues?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was testing this on my fork. Here's the build out put without setting up java: https://github.com/jack-berg/opentelemetry-java/actions/runs/5204819774/jobs/9389527088

Copy link
Member

@trask trask Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I think we're good to remove

Commented on wrong thread

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2819f72) 91.34% compared to head (77cad5e) 91.34%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5511   +/-   ##
=========================================
  Coverage     91.34%   91.34%           
  Complexity     4957     4957           
=========================================
  Files           550      550           
  Lines         14543    14543           
  Branches       1359     1359           
=========================================
  Hits          13285    13285           
  Misses          872      872           
  Partials        386      386           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, i'm guessing it didn't spit out a useful error to give us any clues?

@jack-berg jack-berg merged commit b23ef18 into open-telemetry:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants