-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark opentracing-shim as stable #5371
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5371 +/- ##
=========================================
Coverage 91.20% 91.20%
Complexity 4866 4866
=========================================
Files 546 546
Lines 14373 14373
Branches 1351 1351
=========================================
Hits 13109 13109
Misses 875 875
Partials 389 389 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cc @tylerbenson for an additional review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are parts of the code that could use some more comments (for example TracerShim.maybeUnobfuscate
. I think the readme could also use a section to document some of the incongruences between the APIs, for example in OTel baggage is immutable.
I don't think these prevent marking it as stable though.
@carlosalberto / @jkwatson I think this is ready to go and is low risk given the tiny API surface area, but we lack approvals required to merge for May release. |
Thanks for raising this @jack-berg ! |
cc @carlosalberto