Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setEpoch to setTimestamp #5368

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

jack-berg
Copy link
Member

Was adding support observed timestamp and I noticed LogRecordBuilder#setEpoch is poorly named. The log record data model has two timestamp fields (timestamp and observed timstamp), and setEpoch is ambiguous about which is being set.

Let's get this resolved before stabilizing. I propose we rename to setTimestamp, which is more clear.

@jack-berg jack-berg requested a review from a team April 10, 2023 21:04
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (ecc41c7) 91.18% compared to head (0b29507) 91.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5368      +/-   ##
============================================
+ Coverage     91.18%   91.20%   +0.01%     
  Complexity     4865     4865              
============================================
  Files           546      546              
  Lines         14369    14373       +4     
  Branches       1351     1351              
============================================
+ Hits          13103    13109       +6     
  Misses          875      875              
+ Partials        391      389       -2     
Impacted Files Coverage Δ
.../java/io/opentelemetry/api/logs/DefaultLogger.java 100.00% <ø> (ø)
...va/io/opentelemetry/api/logs/LogRecordBuilder.java 60.00% <ø> (ø)
...y/exporter/logging/SystemOutLogRecordExporter.java 92.85% <100.00%> (ø)
...etry/exporter/internal/otlp/logs/LogMarshaler.java 67.10% <100.00%> (ø)
...metry/sdk/testing/assertj/LogRecordDataAssert.java 100.00% <100.00%> (ø)
...ntelemetry/sdk/testing/logs/TestLogRecordData.java 100.00% <100.00%> (ø)
...io/opentelemetry/sdk/logs/SdkLogRecordBuilder.java 97.61% <100.00%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Love it. Thank you! Easy win.

@jack-berg jack-berg merged commit 0a34867 into open-telemetry:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants