Bump com.google.protobuf:protobuf-bom from 3.21.12 to 3.22.0 #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [com.google.protobuf:protobuf-bom](https://github.com/protocolbuffers/protobuf) from 3.21.12 to 3.22.0. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.21.12...v3.22.0) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
looks like this might not be a simple upgrade.... |
|
Ugh.. spent some time trying to resolve this and have some frustrating updates:
|
|
Happened to find this and take a look since it's about proto. For history, when migrating jaeger-remote-sampler to "grpc lite", we could have taken the same strategy as the jaeger exporter and created a separate proto artifact for the now unused code. Probably just completely forgot to think about that. For the code diffs, from what I can tell is that overrides within the generated subclasses were removed in favor of only using parent class implementations. I believe @jkwatson taught us once that this is actually a compatible change, code linked with the subclass method will actually call the parent one if removed - japicmp sometimes has had false positives and looks like this may be one of them. |
|
Thanks for taking a look @anuraaga. Will double check that the implementation is still on the parent, and if so, find a way to suppress japicmp from failing on this specific case. |
jack-berg
reviewed
Mar 7, 2023
| @Test | ||
| @SuppressWarnings({"ModifiedButNotUsed", "ReturnValueIgnored"}) | ||
| @Disabled | ||
| void compatibility() { |
There was a problem hiding this comment.
This test confirms what @anuraaga asserts, which is that the methods have been moved to the parent class.
I've added an exception for this condition to japicmp. If folks agree, I'll delete this test before merging, and remove the japicmp exception after the next release.
jack-berg
approved these changes
Mar 7, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
============================================
- Coverage 91.08% 90.92% -0.17%
- Complexity 4876 4884 +8
============================================
Files 549 550 +1
Lines 14421 14476 +55
Branches 1372 1370 -2
============================================
+ Hits 13136 13162 +26
- Misses 891 917 +26
- Partials 394 397 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkwatson
approved these changes
Mar 8, 2023
|
A newer version of com.google.protobuf:protobuf-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
jack-berg
deleted the
dependabot/gradle/com.google.protobuf-protobuf-bom-3.22.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps com.google.protobuf:protobuf-bom from 3.21.12 to 3.22.0.
Commits
a847a8dUpdating version.json and repo version numbers to: 22.052e435dMerge pull request #11970 from deannagarcia/updateDepsd327259Update UPB dep8d7b4e6Merge pull request #11946 from protocolbuffers/cp-enum-closed-commenta594141Document known quirks of EnumDescriptor::is_closed() when importing across fi...b7f7171Merge pull request #11944 from protocolbuffers/gha-port-22.xd39aeacFixing broken rust package9a5e86dRun continuous tests hourly to boost statistics for analysisde8bb71[ObjC] CI dbg & opt macOS bazel builds.a3970efStop using 'push' event to determine privileged post-submit runs.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)