Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge :sdk:metrics-testing into :sdk:testing #5144

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

jack-berg
Copy link
Member

With exponential histogram stable, there's nothing left in :sdk:metrics-testing so it can be deleted.

@jack-berg jack-berg requested a review from a team January 21, 2023 16:31
@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 91.11% // Head: 91.14% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (857e5c8) compared to base (c427bf2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5144      +/-   ##
============================================
+ Coverage     91.11%   91.14%   +0.03%     
- Complexity     4905     4933      +28     
============================================
  Files           547      551       +4     
  Lines         14503    14576      +73     
  Branches       1393     1396       +3     
============================================
+ Hits          13214    13286      +72     
- Misses          891      894       +3     
+ Partials        398      396       -2     
Impacted Files Coverage Δ
...l/data/ImmutableExponentialHistogramPointData.java 100.00% <ø> (ø)
...ing/assertj/ExponentialHistogramBucketsAssert.java 100.00% <ø> (ø)
...nal/data/ImmutableExponentialHistogramBuckets.java 100.00% <100.00%> (ø)
...dk/testing/assertj/ExponentialHistogramAssert.java 100.00% <100.00%> (ø)
...sting/assertj/ExponentialHistogramPointAssert.java 100.00% <100.00%> (ø)
...pentelemetry/sdk/testing/assertj/MetricAssert.java 95.65% <100.00%> (+0.41%) ⬆️
...gregator/DoubleExponentialHistogramAggregator.java 93.33% <0.00%> (-3.34%) ⬇️
...metry/sdk/metrics/export/PeriodicMetricReader.java 90.00% <0.00%> (+2.85%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkwatson jkwatson merged commit 5904380 into open-telemetry:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants