Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working #5090 and noticed that
MetricReader
didn't implementCloseable
.Adjusted
MetricReader
to extendCloseable
, and added a default implementation so the change is backwards compatible. Ran into some issues where japicmp was flagging a false positive that the change was breaking. Ended up needing to dive deeper into the japicmp gradle plugin than I wanted to to discover the source of the bug, but along the way found some better ways to organize our config which make it easier to comprehend.