Remove BaseShimObject, TelemetryInfo #5087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going through the opentracing shim and noticed that a few things making the code more complicated than needed. Most classes extend BaseShimObject, which simply gives access to TelemetryInfo fields. TelemetryInfo is just a holder for a Tracer, Baggage.empty(), and OpenTracingPropagators. I've adjusted the code so each of the components only has the things it needs (normally either Tracer or OpenTracingPropagators) and removed the BaseShimObject. The result is simpler and easier to understand.
I've also reduced the visibility of a few constructors and methods.