Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigUtil internally #5048

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Conversation

jack-berg
Copy link
Member

There are a few places where we read from system properties. This adjusts those to use ConfigUtil so that property names normalization occurs in a standard way.

@jack-berg jack-berg requested a review from a team December 16, 2022 18:04
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 91.25% // Head: 91.24% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8fc3864) compared to base (57595b0).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5048      +/-   ##
============================================
- Coverage     91.25%   91.24%   -0.01%     
+ Complexity     4894     4893       -1     
============================================
  Files           552      552              
  Lines         14481    14479       -2     
  Branches       1386     1385       -1     
============================================
- Hits          13214    13212       -2     
  Misses          878      878              
  Partials        389      389              
Impacted Files Coverage Δ
...y/exporter/internal/marshal/CodedOutputStream.java 70.76% <33.33%> (-0.25%) ⬇️
...java/io/opentelemetry/api/GlobalOpenTelemetry.java 93.33% <100.00%> (ø)
...java/io/opentelemetry/api/internal/ConfigUtil.java 100.00% <100.00%> (ø)
...emetry/sdk/metrics/internal/debug/DebugConfig.java 100.00% <100.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit ece93b7 into open-telemetry:main Dec 17, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants