Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxScale config parameter to ExponentialHistogram #5044

Merged

Conversation

jack-berg
Copy link
Member

Implements spec opentelemetry-specification#3017.

As stated in opentelemetry-specification#2987), this would allow performance sensitive applications to reduce the number of rescales and avoid the performance hit of computing histogram bucket using the log approach required for positive scales, which is slower than bitshifting approach used when scale is <= 0. I suspect only the most extreme applications would care to set this since its pretty extreme to care about a single call to Math.log being on the hot path.

@jack-berg jack-berg requested a review from a team December 14, 2022 21:16
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 91.24% // Head: 91.22% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (aa269c7) compared to base (16a02b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5044      +/-   ##
============================================
- Coverage     91.24%   91.22%   -0.02%     
- Complexity     4883     4884       +1     
============================================
  Files           553      553              
  Lines         14449    14451       +2     
  Branches       1379     1380       +1     
============================================
- Hits          13184    13183       -1     
- Misses          878      879       +1     
- Partials        387      389       +2     
Impacted Files Coverage Δ
...gregator/DoubleExponentialHistogramAggregator.java 96.66% <100.00%> (ø)
.../aggregator/DoubleExponentialHistogramBuckets.java 83.33% <100.00%> (ø)
...internal/view/ExponentialHistogramAggregation.java 100.00% <100.00%> (ø)
...y/exporter/internal/marshal/CodedOutputStream.java 69.59% <0.00%> (-1.17%) ⬇️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 92.41% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 6, 2023
@jack-berg jack-berg removed the Stale label Jan 6, 2023
@jack-berg jack-berg merged commit b08edb6 into open-telemetry:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants