Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of date zipkin exporter docs #4995

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

jack-berg
Copy link
Member

Resolves #4926.

@jack-berg jack-berg requested a review from a team November 28, 2022 21:02
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 91.21% // Head: 91.24% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (cb2ff26) compared to base (7dd5c1c).
Patch coverage: 96.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4995      +/-   ##
============================================
+ Coverage     91.21%   91.24%   +0.02%     
- Complexity     4841     4848       +7     
============================================
  Files           548      549       +1     
  Lines         14369    14383      +14     
  Branches       1371     1373       +2     
============================================
+ Hits          13107    13124      +17     
+ Misses          873      872       -1     
+ Partials        389      387       -2     
Impacted Files Coverage Δ
...er/zipkin/internal/ZipkinSpanExporterProvider.java 90.00% <90.00%> (ø)
...y/exporter/zipkin/OtelToZipkinSpanTransformer.java 93.10% <100.00%> (+1.10%) ⬆️
...y/sdk/autoconfigure/SpanExporterConfiguration.java 100.00% <100.00%> (+1.21%) ⬆️
...metry/sdk/logs/export/BatchLogRecordProcessor.java 90.07% <0.00%> (+0.70%) ⬆️
...metry/sdk/metrics/export/PeriodicMetricReader.java 90.00% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 0973a7c into open-telemetry:main Nov 29, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTEL_ZIPKIN_ENDPOINT not supported in Zipkin exporter
2 participants