Add a small artifact that joins TracerSdk and InMemorySpanExporter. #494
Conversation
Used for OpenTelemetry integration testing.
carlosalberto
requested review from
arminru,
bogdandrutu,
pavolloffay,
songy23 and
tylerbenson
as code owners
|
Nice you found the same flaky test I mentioned in #487 |
There was a problem hiding this comment.
I think we also need some utils to compare the span ids and trace ids. Probably this just updates #485 and does not fix it.
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.opentelemetry.inmemory.trace; |
There was a problem hiding this comment.
this can probably be in contrib: io.opentelemetry.contrib.inmemory.trace;
There was a problem hiding this comment.
Probably better package io.opentelemetry.sdk.contrib.trace.export;
* Put it under contrib. * Use package io.opentelemetry.sdk.contrib.trace.export
carlosalberto
force-pushed
the
add_inmemory_artifact
branch
from
9a91b79 to
680773a
Compare
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
=========================================
Coverage ? 78.98%
Complexity ? 560
=========================================
Files ? 65
Lines ? 1913
Branches ? 188
=========================================
Hits ? 1511
Misses ? 343
Partials ? 59Continue to review full report at Codecov.
|
|
@songy23 Done @bogdandrutu Updated ;) For the sake of fast iteration, I suggest we merge (if you agree with the new package name), and I will expose the remaining friendly oriented bits (trace/span ids helper functions, SpanData alike wrappers, etc) in another PR. |
contrib/inmemory_export/build.gradle
Outdated
| @@ -0,0 +1,7 @@ | |||
| description = 'OpenTelemetry InMemory Export' | |||
There was a problem hiding this comment.
I prefer to have this in contrib_sdk directory. Contrib is a directory that just depends on the API and contrib_sdk depends on the API + SDK :)
|
@carlosalberto please address the last comment and I will merge. |
|
@bogdandrutu Oh, definitely. Sorry, had missed your previous comment ;) Will update in a bit. |
|
@bogdandrutu Done ;) |
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.opentelemetry.sdk.contrib.trace.export; |
There was a problem hiding this comment.
From java9 I think it is not recommended to export different maven artifacts for the same package. Maybe we should rename the package to something more specific. Please fix this in a separate PR.
Used for OpenTelemetry integration testing.
This exposes the mentioned artifact to make testing easier by exposing a
TracerSdkalong with anInMemorySpanExporter(and we can use this to have some actual examples, similar to the OT Shim testbed cases).The current design keeps the hierarchy used the the API/SDK (which means we can add a
InMemoryMetricsor similar later on).I had been wrapping the proto
Spanobjects in a friendlier class, but dropped that for now, while we theSpanDataissue is solved (so I can either use that or not for this layer).Also, I'm not totally married with the
inmemoryname (alternative wassdk-testingorsdk-inmemory), so I'm open to suggestions ;)