-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipkin exporter: Serialize EventData attributes as JSON #4934
Zipkin exporter: Serialize EventData attributes as JSON #4934
Conversation
Codecov ReportBase: 91.00% // Head: 91.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4934 +/- ##
============================================
+ Coverage 91.00% 91.02% +0.01%
- Complexity 4839 4847 +8
============================================
Files 546 547 +1
Lines 14439 14455 +16
Branches 1395 1396 +1
============================================
+ Hits 13140 13157 +17
+ Misses 894 893 -1
Partials 405 405
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! Couple of small comments.
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Outdated
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Outdated
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Outdated
Show resolved
Hide resolved
exporters/zipkin/src/main/java/io/opentelemetry/exporter/zipkin/EventDataToAnnotation.java
Show resolved
Hide resolved
…ry#4934) * serialize EventData attributes to json * remove import * fix test * address code review comments. * safety first
Resolves #4859.