Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LogEmitter to Logger, LogEmitterProvider to LoggerProvider #4721

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

jack-berg
Copy link
Member

Related to #4714.

@jack-berg jack-berg requested a review from a user August 24, 2022 20:58
@jack-berg jack-berg requested a review from Oberon00 as a code owner August 24, 2022 20:58
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Base: 90.77% // Head: 90.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (25a27ee) compared to base (a50ceb3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4721   +/-   ##
=========================================
  Coverage     90.77%   90.78%           
- Complexity     4817     4818    +1     
=========================================
  Files           551      551           
  Lines         14366    14364    -2     
  Branches       1397     1397           
=========================================
- Hits          13041    13040    -1     
  Misses          909      909           
+ Partials        416      415    -1     
Impacted Files Coverage Δ
...autoconfigure/spi/AutoConfigurationCustomizer.java 0.00% <ø> (ø)
...main/java/io/opentelemetry/sdk/logs/LogLimits.java 100.00% <ø> (ø)
...n/java/io/opentelemetry/sdk/logs/LogProcessor.java 85.71% <ø> (ø)
...va/io/opentelemetry/sdk/logs/LogRecordBuilder.java 60.00% <ø> (ø)
...a/io/opentelemetry/sdk/logs/LoggerSharedState.java 100.00% <ø> (ø)
.../io/opentelemetry/sdk/logs/export/LogExporter.java 91.66% <ø> (ø)
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java 94.59% <100.00%> (-0.04%) ⬇️
...sdk/autoconfigure/LoggerProviderConfiguration.java 91.66% <100.00%> (ø)
...in/java/io/opentelemetry/sdk/OpenTelemetrySdk.java 96.42% <100.00%> (ø)
.../io/opentelemetry/sdk/OpenTelemetrySdkBuilder.java 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 7, 2022
@jack-berg jack-berg removed the Stale label Sep 7, 2022
@jack-berg
Copy link
Member Author

Not stale, but blocked until spec PR 2768 is merged.

@jack-berg
Copy link
Member Author

Spec PR #2768 has been merged so we should be safe to proceed with this.

@jack-berg jack-berg requested a review from a team September 16, 2022 18:21
@jack-berg jack-berg merged commit 6209109 into open-telemetry:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants