-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return noop instrument if name is invalid #4383
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4383 +/- ##
============================================
+ Coverage 89.94% 90.00% +0.05%
- Complexity 4908 4920 +12
============================================
Files 567 567
Lines 15199 15219 +20
Branches 1465 1465
============================================
+ Hits 13671 13698 +27
+ Misses 1058 1051 -7
Partials 470 470
Continue to review full report at Codecov.
|
Resolves #4378.
I think returning a noop instrument is the least wrong solution: