OTLP metric exporter accepts aggregation temporality function #4340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been uncomfortable with the fact that
setPreferredTemporality(AggregationTemporality)
only allows two options (DELTA
andCUMULATIVE
) when others are possible. What would we do ifOTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
were to add a third option? Also, that selectingDELTA
specifies a preference for delta that applies in most but not all cases.This adjusts
OtlpHttpMetricExporter
andOtlpGrpcMetricExporter
to accept aFunction<InstrumentType, AggregationTemporality>
instead ofAggregationTemporality
.This offers more flexibility and would be needed in the future when we want to support alternative aggregation temporality configs besides the "cumulative" and "delta preferred". To assist with setting
Function<InstrumentType, AggregationTemporality>
, I've added two helper functions toMetricExporter
which represent common aggregation temporality configurations.