Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MeterProvider#get(..) methods #3812

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

jack-berg
Copy link
Member

In PR #3759 there was a comment about removing the SdkLogEmitterProvider#get(...) methods which are made obsolete by SdkLogEmitterProvider#logEmitterBuilder(..).

The same is true for the MeterProvider#get(..). This PR marks them as deprecated and changes all usages to MeterProvider#meterBuilder(..).

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #3812 (9d63084) into main (1f22239) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3812      +/-   ##
============================================
- Coverage     89.22%   89.20%   -0.03%     
- Complexity     4010     4041      +31     
============================================
  Files           481      486       +5     
  Lines         12430    12524      +94     
  Branches       1207     1221      +14     
============================================
+ Hits          11091    11172      +81     
- Misses          926      935       +9     
- Partials        413      417       +4     
Impacted Files Coverage Δ
...va/io/opentelemetry/api/metrics/MeterProvider.java 33.33% <ø> (-66.67%) ⬇️
...io/opentelemetry/sdk/metrics/SdkMeterProvider.java 82.75% <ø> (ø)
.../metrics/internal/descriptor/MetricDescriptor.java 90.90% <0.00%> (-9.10%) ⬇️
...emetry/api/baggage/propagation/PercentEscaper.java 79.69% <0.00%> (-4.52%) ⬇️
...metry/sdk/metrics/export/PeriodicMetricReader.java 81.66% <0.00%> (-3.34%) ⬇️
.../exporter/otlp/internal/okhttp/OkHttpExporter.java 85.24% <0.00%> (-1.43%) ⬇️
...n/java/io/opentelemetry/sdk/metrics/view/View.java 100.00% <0.00%> (ø)
...nternal/state/DuplicateMetricStorageException.java 100.00% <0.00%> (ø)
.../incubator/trace/ExecutorServiceSpanProcessor.java 91.96% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22239...9d63084. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with leaving default, simple Meter get(name).

@anuraaga anuraaga merged commit 8d96cb8 into open-telemetry:main Nov 5, 2021
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants