-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate MeterProvider#get(..) methods #3812
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3812 +/- ##
============================================
- Coverage 89.22% 89.20% -0.03%
- Complexity 4010 4041 +31
============================================
Files 481 486 +5
Lines 12430 12524 +94
Branches 1207 1221 +14
============================================
+ Hits 11091 11172 +81
- Misses 926 935 +9
- Partials 413 417 +4
Continue to review full report at Codecov.
|
api/metrics/src/main/java/io/opentelemetry/api/metrics/MeterProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with leaving default, simple Meter get(name).
In PR #3759 there was a comment about removing the
SdkLogEmitterProvider#get(...)
methods which are made obsolete bySdkLogEmitterProvider#logEmitterBuilder(..)
.The same is true for the
MeterProvider#get(..)
. This PR marks them as deprecated and changes all usages toMeterProvider#meterBuilder(..)
.