Tweak the semantic convention code generation.

[jkwatson]

In particular, to better support links and html in the docs.

[ghost]

👍

[Oberon00]

You could also try using render_markdown(code="{{@code {0}}}"). Pro: Will look a bit more idiomatic, con: Would probably break if there are } in the input.

[Oberon00]

Suggested change

	* {% filter safe %}{{attribute.brief | render_markdown}}{% endfilter %}
	* {{attribute.brief | render_markdown | safe}}

[jkwatson]

I don't even think it needs the | safe which I believe is a no-op.

[Oberon00]

Suggested change

	* <p>Notes: {% filter safe %}{{attribute.note | render_markdown}}{% endfilter %}
	* <p>Notes: {{attribute.note | render_markdown | safe}}

[jkwatson]

You could also try using render_markdown(code="{{@code {0}}}"). Pro: Will look a bit more idiomatic, con: Would probably break if there are } in the input.

Can you explain/point to docs about what this is doing? @breedx-splk and I spent an hour yesterday trying to figure out how to send code blocks into the python via the jinja template and never saw anything like this (and never got anything working, either).

[Oberon00]

Unfortunately, there is no documentation for this one. 😬

• This is the parameter: https://github.com/open-telemetry/build-tools/blob/v0.4.1/semantic-conventions/src/opentelemetry/semconv/templating/code.py#L42
• Which is used here: https://github.com/open-telemetry/build-tools/blob/v0.4.1/semantic-conventions/src/opentelemetry/semconv/templating/code.py#L102
• This uses Python's str.format which uses the syntax documented here: https://docs.python.org/3/library/string.html#formatstrings

[Oberon00]

So instead of <code>sometext</code> you will end up with {@code sometext}.

[jkwatson]

Unfortunately, there is no documentation for this one. 😬

• This is the parameter: https://github.com/open-telemetry/build-tools/blob/v0.4.1/semantic-conventions/src/opentelemetry/semconv/templating/code.py#L42
• Which is used here: https://github.com/open-telemetry/build-tools/blob/v0.4.1/semantic-conventions/src/opentelemetry/semconv/templating/code.py#L102
• This uses Python's str.format which uses the syntax documented here: https://docs.python.org/3/library/string.html#formatstrings

Also unfortunately, it doesn't look like it works. :(

  File "/templates/SemanticAttributes.java.j2", line 67, in template
    * {{attribute.brief | render_markdown(code="{{@code {0}}}"}}
jinja2.exceptions.TemplateSyntaxError: unexpected '}', expected ')'

[Oberon00]

Also unfortunately, it doesn't look like it works. :(

Because you forgot the closing ) between the " and the final }}. 😃

[jkwatson]

Also unfortunately, it doesn't look like it works. :(

Because you forgot the closing ) between the " and the final }}. 😃

Dangit. This code ends up looking like perl.

[Oberon00]

Yeah, too many nesting levels here with quotes and various brackets.

[jkwatson]

Now I have the power! #3398